Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: do nightly polkit builds & submit them to Coverity #523

Merged
merged 1 commit into from
Nov 14, 2024
Merged

Conversation

mrc0mmand
Copy link
Member

Note: I created this PR's branch intentionally directly in the upstream repo, so it has access to the repo secrets with the Coverity token, as PRs from forks can't do that.

Let's reintroduce regular Coverity builds. Since there's a pretty strict rate limit [0], do one nightly build each day, and upload it to Coverity for analysis. The results can be then found in the project dashboard [1].

[0] https://scan.coverity.com/faq#frequency
[1] https://scan.coverity.com/projects/polkit?tab=overview

Resolves: #517

@mrc0mmand mrc0mmand marked this pull request as ready for review November 6, 2024 16:10
results_archive="analysis-results.tgz"
sha=$(git rev-parse --short HEAD)

meson setup build -Dtests=true -Dexamples=true
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be great to turn on as many features as possible to cover things like #486 as well. On the other hand the default configuration is more important probably. I'm not sure.

Copy link
Member Author

@mrc0mmand mrc0mmand Nov 7, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. I went through the available options and thought I enabled all that could be relevant for Coverity (and that are not enabled by default), but I apparently missed some :)

@mrc0mmand

This comment was marked as resolved.

Let's reintroduce regular Coverity builds. Since there's a pretty strict
rate limit [0], do one nightly build each day, and upload it to Coverity
for analysis. The results can be then found in the project dashboard [1].

[0] https://scan.coverity.com/faq#frequency
[1] https://scan.coverity.com/projects/polkit?tab=overview

Resolves: #517
@jrybar-rh jrybar-rh merged commit c3062d3 into main Nov 14, 2024
34 checks passed
@mrc0mmand mrc0mmand deleted the coverity branch November 14, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

polkit and Coverity Scan
3 participants