Improve the default host value #46
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add support for passing the ES host in a query string parameter, allowing for a better experience for standalone deployments - use the current location only when the site runs as an ES site plugin
|
Note that I'm not sure the code itself would be compatible with ES 5.x yet (there might be BC breaks affecting it). But the standalone deployment is a way to try it (even though I'm not yet using ES 5.x). Note that I took the idea of a standalone deployment from https://github.com/royrusso/elasticsearch-HQ. |
|
@polyfractal do you have any interest into merging this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_sitefolder rather than using ES to run this webserver for a site plugin)