Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Graphsupport for the Polypheny JDBC Driver #15

Open
wants to merge 17 commits into
base: master
Choose a base branch
from
Open

Graphsupport for the Polypheny JDBC Driver #15

wants to merge 17 commits into from

Conversation

TobiasHafner
Copy link
Contributor

This pull request introduces several key updates and improvements to the Polypheny JDBC Driver:

  1. Graph Results Support: Added support for handling graph results, including edges and nodes.
  2. Skeleton Code for Paths: Implemented seleton code with todos and not ipmlemented exceptions for path support, pending server-side fix (workin int he interface but not polypheny itself).
  3. Bug Fixes: Addressed issues with broken unit tests and fixed bugs related to time and date conversions.
  4. Standard Compliance Adjustments:
    • Added deprecated annotations to getters as per JDBC 4.3 standards.
    • Introduced an asString method utilized by toString in result sets.
    • Added exceptions for illegal conversions and unimplemented features, particularly paths.
  5. Multi-Model Extension Features: Enhanced support for multi-model queries (batching, named/indexe dparameters, prepared statements...).
  6. Code Cleanup:
    • Removed unnecessary static imports.
    • Improved variable name clarity.
    • Eliminated printouts from tests.

@TobiasHafner TobiasHafner requested a review from vogti July 31, 2024 09:42
gartens
gartens reviewed Jul 31, 2024
View reviewed changes
src/main/java/org/polypheny/jdbc/RpcService.java
@@ -419,13 +420,27 @@ PreparedStatementSignature prepareIndexedStatement( PrepareStatementRequest msg,
}


public PreparedStatementSignature prepareNamedStatement( PrepareStatementRequest msg, int timeout ) throws PrismInterfaceServiceException {
Request.Builder req = newMessage();
req.setPrepareIndexedStatementRequest( msg );
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this not be setPrepareNamedStatementRequest?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gartens gartens gartens left review comments

@vogti vogti Awaiting requested review from vogti

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TobiasHafner @gartens