improv(app-list): get app icons from icon theme #542
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wash2
reviewed
Jul 26, 2024
| @@ -181,8 +181,7 @@ impl DockItem { | |||
|
|
|||
| let app_icon = AppletIconData::new(applet); | |||
|
|
|||
| let cosmic_icon = IconSource::from_unknown(desktop_info.icon().unwrap_or_default()) | |||
| .as_cosmic_icon() | |||
| let cosmic_icon = cosmic::widget::icon::from_name(desktop_info.icon().unwrap_or_default()) | |||
There was a problem hiding this comment.
I believe IconSource::from_unknown is actually correct. Some icons are absolute paths. Maybe app library and launcher should be updated instead. Is the app tray showing the wrong icon?
There was a problem hiding this comment.
It is not applying the icon theme, here Qogir-ubuntu.
It could be checked if the path is absolute or IconSource could be improved.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cosmic-launcher and cosmic-app-libary use widget::icon_from_name, so those have different app icons, which does not look good and is confusing.