WIP Fixes for transformed outputs with mirroring #1091
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply inverse of output transform to mode to get render size, and apply no transform during rendering. The transform of the output being mirrored from shouldn't affect the final render. Fixes issues when source output for mirroring has a transform, and also fixes issues in #1058 when this code is used for postprocessing, where this resulted in the same transform being applied twice.
Careful use of the right `VacantEntry` and `OccupiedEntry` methods makes this possible without hacks or lifetime errors.
To determine if `mirroring_state` is needed, we want to compare the untransformed dimensions of the source output to the target outputs mode. The fact the mode comparision previously compared refresh rate (since it compared the whole `Mode`) seems unintended. We should also re-create the `MirroringState` when the source output dimensions changes. Not sure the exact best API here...
|
I'm not sure the centering is always right either, in some circumstances, though I'll have to test if that's still an issue after other changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also applicable to #1058.
Looks like damage tracking for mirroring with output transforms isn't quite right either (before or after this) so some more fixes are needed.