feat: Gesture configuration backend #396
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ryanabx
force-pushed
the
input/gesture-config
branch
3 times, most recently
from
f89023e to
d42b6df
Compare
ryanabx
force-pushed
the
input/gesture-config
branch
from
d42b6df to
0eccd82
Compare
ryanabx
changed the title
ryanabx
force-pushed
the
input/gesture-config
branch
from
0eccd82 to
38898bf
Compare
|
Rebased to include the RWLock changes. @Drakulix can you look at this at some point? I think this is a good direction to go for gesture configurations but I need to know if you and others agree |
Drakulix
reviewed
Apr 17, 2024
cosmic-comp-config/src/input.rs
Outdated
| WindowLeft, | ||
| WindowRight, | ||
| Custom(String), | ||
| } |
There was a problem hiding this comment.
Do we really need another enum for this? We already have the Action-enum that is used for key-bindings. Can't we just use that and special case some actions like NextWorkspace/PreviousWorkspace when using gestures? (To animate those properly.)
That would make configuration much more flexible and allow binding more things to gestures.
There was a problem hiding this comment.
Sure, I'll look into doing that
There was a problem hiding this comment.
After looking into it, I'll hold onto this PR until #400 is finished, because it moves the Actions enum into cosmic-comp-config, where I need it
ryanabx
force-pushed
the
input/gesture-config
branch
from
38898bf to
9319fe3
Compare
|
Going to start working on this again. But it looks like actions and keybinds are defined in c-s-d, so I'm going to make the proper gesture type there first! |
ryanabx
added a commit
to ryanabx-contrib/cosmic-settings-daemon
that referenced
this pull request
Dec 20, 2024
This commit adds a Gesture abstraction, which can define gestures by the number of fingers used, and the direction the gesture is performed in. Oftentimes, we want the gesture to be either absolute (i.e. ignoring context such as workspace direction), or relative (if workspaces are horizontal, forward would be right, backward would be left. if workspaces are vertical, forward would be up, backward would be down). The abstraction is modeled after the Binding type, and the resulting Gestures type is similar to the Shortcuts type. This is the first step in implementing configurable touchpad gestures (pop-os/cosmic-comp#396) Signed-off-by: Ryan Brue <[email protected]>
ryanabx
added a commit
to ryanabx-contrib/cosmic-settings-daemon
that referenced
this pull request
Dec 20, 2024
This commit adds a Gesture abstraction, which can define gestures by the number of fingers used, and the direction the gesture is performed in. Oftentimes, we want the gesture to be either absolute (i.e. ignoring context such as workspace direction), or relative (if workspaces are horizontal, forward would be right, backward would be left. if workspaces are vertical, forward would be up, backward would be down). The abstraction is modeled after the Binding type, and the resulting Gestures type is similar to the Shortcuts type. This is the first step in implementing configurable touchpad gestures (pop-os/cosmic-comp#396) Signed-off-by: Ryan Brue <[email protected]>
ryanabx
added a commit
to ryanabx-contrib/cosmic-settings-daemon
that referenced
this pull request
Dec 23, 2024
This commit adds a Gesture abstraction, which can define gestures by the number of fingers used, and the direction the gesture is performed in. Oftentimes, we want the gesture to be either absolute (i.e. ignoring context such as workspace direction), or relative (if workspaces are horizontal, forward would be right, backward would be left. if workspaces are vertical, forward would be up, backward would be down). The abstraction is modeled after the Binding type, and the resulting Gestures type is similar to the Shortcuts type. This is the first step in implementing configurable touchpad gestures (pop-os/cosmic-comp#396) Signed-off-by: Ryan Brue <[email protected]>
ryanabx
added a commit
to ryanabx-contrib/cosmic-settings-daemon
that referenced
this pull request
Dec 23, 2024
This commit adds a Gesture abstraction, which can define gestures by the number of fingers used, and the direction the gesture is performed in. Oftentimes, we want the gesture to be either absolute (i.e. ignoring context such as workspace direction), or relative (if workspaces are horizontal, forward would be right, backward would be left. if workspaces are vertical, forward would be up, backward would be down). The abstraction is modeled after the Binding type, and the resulting Gestures type is similar to the Shortcuts type. This is the first step in implementing configurable touchpad gestures (pop-os/cosmic-comp#396) Signed-off-by: Ryan Brue <[email protected]>
ryanabx
added a commit
to ryanabx-contrib/cosmic-settings-daemon
that referenced
this pull request
Dec 23, 2024
This commit adds a Gesture abstraction, which can define gestures by the number of fingers used, and the direction the gesture is performed in. Oftentimes, we want the gesture to be either absolute (i.e. ignoring context such as workspace direction), or relative (if workspaces are horizontal, forward would be right, backward would be left. if workspaces are vertical, forward would be up, backward would be down). The abstraction is modeled after the Binding type, and the resulting Gestures type is similar to the Shortcuts type. This is the first step in implementing configurable touchpad gestures (pop-os/cosmic-comp#396) Signed-off-by: Ryan Brue <[email protected]>
ryanabx
added a commit
to ryanabx-contrib/cosmic-settings-daemon
that referenced
this pull request
Dec 23, 2024
This commit adds a Gesture abstraction, which can define gestures by the number of fingers used, and the direction the gesture is performed in. Oftentimes, we want the gesture to be either absolute (i.e. ignoring context such as workspace direction), or relative (if workspaces are horizontal, forward would be right, backward would be left. if workspaces are vertical, forward would be up, backward would be down). The abstraction is modeled after the Binding type, and the resulting Gestures type is similar to the Shortcuts type. This is the first step in implementing configurable touchpad gestures (pop-os/cosmic-comp#396) Signed-off-by: Ryan Brue <[email protected]>
ryanabx
added a commit
to ryanabx-contrib/cosmic-settings-daemon
that referenced
this pull request
Dec 23, 2024
This commit adds a Gesture abstraction, which can define gestures by the number of fingers used, and the direction the gesture is performed in. Oftentimes, we want the gesture to be either absolute (i.e. ignoring context such as workspace direction), or relative (if workspaces are horizontal, forward would be right, backward would be left. if workspaces are vertical, forward would be up, backward would be down). The abstraction is modeled after the Binding type, and the resulting Gestures type is similar to the Shortcuts type. This is the first step in implementing configurable touchpad gestures (pop-os/cosmic-comp#396) Signed-off-by: Ryan Brue <[email protected]>
ryanabx
force-pushed
the
input/gesture-config
branch
from
9319fe3 to
316d95d
Compare
ryanabx
added a commit
to ryanabx-contrib/cosmic-settings-daemon
that referenced
this pull request
Dec 23, 2024
This commit adds a Gesture abstraction, which can define gestures by the number of fingers used, and the direction the gesture is performed in. The abstraction is modeled after the Binding type, and the resulting Gestures type is similar to the Shortcuts type. This is the first step in implementing configurable touchpad gestures (pop-os/cosmic-comp#396) Signed-off-by: Ryan Brue <[email protected]>
ryanabx
force-pushed
the
input/gesture-config
branch
from
316d95d to
e48e352
Compare
…aemon config This commit adds very very simple configurable touchpad gestures, starting with next and previous workspace. We need to add support for more actions at some point, but this is a good start. Signed-off-by: Ryan Brue <[email protected]>
|
I think this should be ready now, pending pop-os/cosmic-settings-daemon#63 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depends on: pop-os/cosmic-settings-daemon#63
This PR has been updated as of 2024-12-23
This version of the gesture configuration backend is very simple to start, only supporting the gestures that are currently supported prior to this PR (i.e. next and previous workspace).
Using the
custom_gesturesconfiguration in cosmic-settings-daemon's config, you can specify custom gestures to override the default gesture configuration.