Deterministic unit tests #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The previous unit tests depended on several packages which included themes, such as Adwaita; as well as programs, such as Firefox. I modified the unit tests to not depend on anything which should help distros that package Rust dependencies AND run unit tests (which I think Debian does?).
|
Also, the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I fixed all of the unit tests and doc tests so they compile and pass. Previously, the unit tests would fail because they depended on certain programs or themes installed.
I created a fake theme hierarchy so we have more control over tests. I also fixed the doc tests which referred to the old crate which caused them to fail to compile.
Finally, I fixed up the README in the same way.