-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: feat(gui): Support for verifying written data #118
base: master
Are you sure you want to change the base?
Conversation
Using feature that was already available in the CLI.
There's a GUI Design page in the Wiki https://github.com/pop-os/popsicle/wiki/GUI-Design |
As for the UI for the verification stage, this occurs after flashing. Popsicle reads back the data written to the USB drive to make sure it matches what was in the image. Since reading is faster than writing, depending on image size and drive speed this seems to happen fast enough that it's easy to miss the verification stage if one isn't very carefully watching the program while it flashes. |
Does the verifying happen drive-by-drive once each drive is done flashing, or all at once after all are done flashing? If the former, I think what you have makes sense, though maybe the title could change to "Flashing & Verifying…" to be more clear the option is enabled, then on the complete page you could add a note about the fact that they were verified as well. e.g.:
If the drives are all verified after they've all been flashed, then it would make sense for this to occur on a new step with its own title. e.g.:
|
It verifies drive-by-drive when they are done flashing. Good idea about making the button say "Flash & Verify". |
Using feature that was already available in the CLI.
This works, but I'm not quite sure how to fit it in the UI. I don't think it looks quite right here: