Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(layout): v2 퀵가이드에서 사이즈가 줄어들경우 래이아웃이 찌그러지는 버그 수정 #714

Merged
merged 6 commits into from
Dec 26, 2024

Conversation

CreeJee
Copy link
Contributor

@CreeJee CreeJee commented Dec 22, 2024

사이즈가 일그러지는 버그를 수정했습니당

AS-IS TO-BE
image image

@CreeJee CreeJee requested a review from a team as a code owner December 22, 2024 10:09
Copy link

vercel bot commented Dec 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
developers ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 26, 2024 2:29am

@CreeJee CreeJee marked this pull request as draft December 22, 2024 11:41
@CreeJee CreeJee marked this pull request as ready for review December 22, 2024 12:45
@CreeJee CreeJee changed the title fix(docs): v2 퀵가이드에서 사이즈가 줄어들경우 래이아웃이 찌그러지는 버그 수정 fix(layout): v2 퀵가이드에서 사이즈가 줄어들경우 래이아웃이 찌그러지는 버그 수정 Dec 22, 2024
@CirnoV
Copy link
Member

CirnoV commented Dec 23, 2024

image
image

이렇게 하면 스크롤 내렸을 때 선택하는 부분이 가려지네요 😢
flex-wrap 안 한 사이즈를 기준으로 sticky top 수치를 주고 있어서 그런 것 같은데, 좋은 방법 있을까요?

@CreeJee
Copy link
Contributor Author

CreeJee commented Dec 23, 2024

@CirnoV 음 조금 고민이 되기는하는데요
저부분을 한다고 하면 top 관련된 수치를 지우고 켄테이너 넓이에 맞춰 따라갈수있게 재구상해야할것같아여

조금더 확인해보겟습니다~

@CreeJee CreeJee marked this pull request as draft December 23, 2024 09:04
@CirnoV
Copy link
Member

CirnoV commented Dec 23, 2024

@CreeJee 추후에 <lg(1024px) 에서는 언어 선택 부분이 Select로 변경 될 예정이어서, 요 부분도 참고해주시면 좋을 것 같아요! (Slack)

@CreeJee
Copy link
Contributor Author

CreeJee commented Dec 23, 2024

  • 음 린트가 조금이상한대 내일볼게염...
  • 수정되었습니다!

@CirnoV CirnoV merged commit 50d8b67 into main Dec 26, 2024
2 of 3 checks passed
@CirnoV CirnoV deleted the fix-quick-guide branch December 26, 2024 02:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants