Skip to content
This repository has been archived by the owner on Nov 9, 2021. It is now read-only.

Template modification to simplify applying styles #79

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Template modification to simplify applying styles #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 7 additions & 5 deletions addon/templates/components/bread-crumb.hbs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,11 @@
{{/if}}
{{/link-to}}
{{else}}
{{#if hasBlock}}
{{yield this route}}
{{else}}
{{route.title}}
{{/if}}
<span>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the <span> should wrap the yield as it would prevent you from using any other elements.
Maybe consider it as a default for the case where the is no block given?

{{#if hasBlock}}
{{yield this route}}
{{else}}
{{route.title}}
{{/if}}
</span>
{{/if}}