-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ability to manage output area of tablet handler #6166
base: master
Are you sure you want to change the base?
Conversation
/// <summary> | ||
/// Position of output area inside game window, 0 is top-left position, 1 is bottom-right. | ||
/// </summary> | ||
Bindable<Vector2> OutputAreaPosition { get; } |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I understand correctly, this is the relative position of the centre of the output area? It should probably be mentioned as such in the xmldoc.
/// </summary> | ||
/// <remarks> | ||
/// This and <see cref="OutputAreaSize"/> behave like posX/posY/sizeX/sizeY properties on osu!'s ScalingContainer. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please don't reference game-side classes in framework xmldoc, that's backwards
Partially does #6150 .
Exposes area position / size bindables, implements their application.
Manually tested this in different scaling modes with different window sizes/positions on display, seems to work as expected.
Ad-hoc diff for osu!: