Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add TrackLoudness (BASSloud) #6281

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add TrackLoudness (BASSloud) #6281

wants to merge 3 commits into from

Conversation

hwsmm
Copy link
Contributor

@hwsmm hwsmm commented May 12, 2024 •
edited
Loading

This PR makes TrackLoudness available in framework for ppy/osu#27793.

Diff from peppy/ManagedBass#1 (comment) is also needed, but I can revert this if anyone doesn't want. reverted.

@hwsmm hwsmm mentioned this pull request May 12, 2024
Merged
@hwsmm @smallketchup82
Add TrackLoudness (BASSloud)
88450e1 
Co-authored-by: smallketchup82 <[email protected]>
smallketchup82
smallketchup82 reviewed May 12, 2024
View reviewed changes
Copy link

@smallketchup82 smallketchup82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Despite the fact that I'm yet to test this, the diff alone looks fine.

osu.Framework/Audio/Track/TrackLoudness.cs Outdated Show resolved Hide resolved
smallketchup82
smallketchup82 suggested changes May 13, 2024
View reviewed changes
Copy link

@smallketchup82 smallketchup82 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from minor work on error handling and the previous review, this should be good to go

osu.Framework/Audio/Track/TrackLoudness.cs Outdated Show resolved Hide resolved
osu.Framework/Audio/Track/TrackLoudness.cs Outdated Show resolved Hide resolved
osu.Framework/Audio/Track/TrackLoudness.cs Outdated Show resolved Hide resolved
smallketchup82
smallketchup82 approved these changes May 13, 2024
View reviewed changes
Copy link

@smallketchup82 smallketchup82 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@smallketchup82 smallketchup82 mentioned this pull request May 20, 2024
Open
@smallketchup82 smallketchup82 mentioned this pull request Oct 16, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smallketchup82 smallketchup82 smallketchup82 approved these changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hwsmm @smallketchup82