-
Notifications
You must be signed in to change notification settings - Fork 422
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose tablet OutputSize #6460
Open
DanielPower
wants to merge
17
commits into
ppy:master
Choose a base branch
from
DanielPower:screen-scaling-tablet-output
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Expose tablet OutputSize #6460
Changes from all commits
Commits
Show all changes
17 commits
Select commit
Hold shift + click to select a range
7bac31e
Add output area and size to OTD handler
Feodor0090 56db884
Expose area properties via `ITabletHandler`
Feodor0090 abc34ab
Add better explanation how `OutputAreaPosition` works
Feodor0090 f8aab30
Remove mention about osu!'s component
Feodor0090 eee564b
Initial proof of concept for tablet output scaling
DanielPower 9820c11
Remove console log
DanielPower 082e586
Merge remote-tracking branch 'feodor0090/tablet-output-area' into scr…
DanielPower 9ced124
Merge remote-tracking branch 'feodor0090/tablet-output-area' into scr…
DanielPower a547cc4
Merge remote-tracking branch 'fork/screen-scaling-tablet-output' into…
DanielPower 782d505
Fix unintended changes from merging old branch
DanielPower 59c2b5f
Undo unintended change
DanielPower 93ca8c0
Update wording for OutputAreaPosition summary
DanielPower 93b2feb
Remove trivial comments
DanielPower 1f3075e
Simplify scaling/positioning logic
DanielPower 679c19f
Address ambiguous arithmetic precedence
DanielPower a059213
Address ambiguous arithmetic precedence
DanielPower 6cc3d7f
Minor cleanup
DanielPower File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
what is this change? this removal does not look correct in this context