Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Take focus from game during calls on iOS #6462

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

frenzibyte
Copy link
Member

@frenzibyte frenzibyte commented Dec 17, 2024

Again, this is not normal behaviour of any iOS app, as incoming calls have recently been acting more like a glorified notification than a full-screen overlay. However, as a rhythm game, exclusive access to the audio is required for the game to function appropriately, therefore we have to observe for incoming calls and cut focus from the game in order to be aware that it should not remain operating (i.e. send to pause screen).

Note that this change is made primarily because users would otherwise lose their scores when they get a call, as the beatmap freezes and osu! triggers the "you have an issue with your audio device, score will not be submitted" notification.

The framework may not be exclusively for rhythm games, but I think it's simple to have this anyway until we get a report about it from other framework consumers.

Visual indicators do not help when the app is sent to the background.
@peppy
Copy link
Member

peppy commented Dec 17, 2024

To clarify, this is avoiding the game becoming unusable when a phone call arrives? Because your description sounds like this is an optional change, and not having it would just mean that the phone call notification shows on top of the game.

Maybe you could show a video of what happens with/without this to clarify.

@frenzibyte
Copy link
Member Author

frenzibyte commented Dec 17, 2024

I briefly mentioned it in #6449 (comment) but forgot to mention here. This change is mandatory for osu!, otherwise when someone receives a call the beatmap freezes and osu! thinks the audio system is at fault and excludes the score from submission. The change fixes the issue by killing focus and taking gameplay to pause screen immediately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Beatmap freezes when answering a call while playing.
2 participants