Skip to content

Commit

Permalink
Fix strong drum rolls being counted for double the combo in legacy sc…
Browse files Browse the repository at this point in the history
…oring attributes
  • Loading branch information
bdach committed Nov 29, 2024
1 parent b71bccc commit 3cfa455
Showing 1 changed file with 7 additions and 0 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -144,6 +144,13 @@ private void simulateHit(HitObject hitObject, ref LegacyScoreAttributes attribut
foreach (var nested in hitObject.NestedHitObjects)
simulateHit(nested, ref attributes);
return;

case StrongNestedHitObject:
// we never need to deal with these directly.
// the only thing strong hits do in terms of scoring is double their object's score increase,
// which is already handled at the parent object level via the `strongable.IsStrong` check lower down in this method.
// not handling these here can lead to them falsely being counted as combo-increasing when handling strong drum rolls!
return;
}

if (hitObject is DrumRollTick tick)
Expand Down

0 comments on commit 3cfa455

Please sign in to comment.