Add keybindings for readying and spectating in multi rooms #31114
Conversation
| new KeyBinding(new[] { InputKey.Control, InputKey.R }, GlobalAction.MultiplayerReady), | ||
| new KeyBinding(new[] { InputKey.Control, InputKey.S }, GlobalAction.MultiplayerSpectate), |
There was a problem hiding this comment.
These seem kinda weird / arbitrary. I'd propose something like ctrl/shift-enter for these or something. Something that has more weight behind it, these are supposed to be primary actions for this screen.
There was a problem hiding this comment.
I'm not sure what to do about this, I just picked whatever made sense for me when I made the PR, but I wasn't actually sure if these keybindings were good or not. Ctrl-enter seems good for the ready button, but I still don't really know what to choose for the spectate button (maybe Ctrl-backspace ? Or leave it unbinded by default ?).
| switch (e.Action) | ||
| { | ||
| case GlobalAction.MultiplayerReady: | ||
| onReadyButtonClick(); |
There was a problem hiding this comment.
| onReadyButtonClick(); | |
| readyButton.TriggerClick(); |
is preferred as that should play out all of the related button animations that play when the button is clicked using the mouse. It's a UX thing. Same for the other hotkey.
There was a problem hiding this comment.
Ah, makes sense. By doing things that way it also looks like the checks I previously did with operationInProgress.Value and !readyButton.Enabled.Value are now useless, so I got rid of those.
Hey, it's my first time trying to contribute here. This PR adds customisable bindings for readying and spectating in multiplayer rooms.
I mostly play mania, and I find it kinda frustrating that I have to use the touchpad of my laptop between each games when I play multi.
To my knowledge there is currently no way to ready up using only the keyboard (if there is then I'm not aware).
I have no idea if this implementation is clean or if there are other things that need to be modified. Let me know if there are any issues.
2024-12-13.16-13-09.mp4