Change beat snap divisor adjust defaults to be Ctrl+Scroll instead of Ctrl+Shift+Scroll #31147
Conversation
…f Ctrl+Shift+Scroll Matches stable. - [ ] Depends on ppy#31146, else this will adjust the global volume.
peppy
changed the title
| new KeyBinding(new[] { InputKey.Control, InputKey.MouseWheelRight }, GlobalAction.EditorCyclePreviousBeatSnapDivisor), | ||
| new KeyBinding(new[] { InputKey.Control, InputKey.MouseWheelLeft }, GlobalAction.EditorCycleNextBeatSnapDivisor), |
There was a problem hiding this comment.
First of all, see comment preceding - with Shift removed this should presumably become
| new KeyBinding(new[] { InputKey.Control, InputKey.MouseWheelRight }, GlobalAction.EditorCyclePreviousBeatSnapDivisor), | |
| new KeyBinding(new[] { InputKey.Control, InputKey.MouseWheelLeft }, GlobalAction.EditorCycleNextBeatSnapDivisor), | |
| new KeyBinding(new[] { InputKey.Control, InputKey.MouseWheelUp }, GlobalAction.EditorCyclePreviousBeatSnapDivisor), | |
| new KeyBinding(new[] { InputKey.Control, InputKey.MouseWheelDown }, GlobalAction.EditorCycleNextBeatSnapDivisor), |
and the comment should be gone.
Secondly, this change won't actually have any effect for anyone who's launched the game before. For these types of changes we've typically bundled realm migrations to change the defaults for users post-facto.
There was a problem hiding this comment.
Yeah I wasn't sure if we want to migrate existing users. If you think that's best I'll add migrations.
There was a problem hiding this comment.
Nobody has complained about the past migrations (likely because they were written smart, i.e. user customisations were not overwritten), so I'd say it'd be a good thing to have them.
There was a problem hiding this comment.
Both issues should be resolved, thanks.
Matches stable.