Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change strain reduction to be on first chronological strains #31181

Open
wants to merge 12 commits into
base: pp-dev
Choose a base branch
from

Conversation

stanriders
Copy link
Member

Supersedes #30923

This change replaces arbitrary length bonus short map nerf with a bit less arbitrary assumption that the first 30 seconds of any map is easier to FC due to them being easily retryable. This also removes current peak strain reduction, repurposing it's code.
The aim/speed/total multipliers are subject to change and are here just to make testing easier

@tsunyoku
Copy link
Member

!diffcalc
RULESET=osu

Copy link

@Natelytle
Copy link
Contributor

As discussed in discord, I'm mildly opposed to this change since it doesn't scale with the length of the map itself, which may cause 5+ minute long maps with their hard parts within the 20-40 second range to evade the nerf while playing almost exactly the same. As well, mappers could abuse players' patience by either adding a long spinner or break to soak up some of the nerfed strains before entering an immediate difficulty spike.

@stanriders
Copy link
Member Author

I don't think adding 30 seconds of low difficulty is invalidating the concept - objects after are still less retryable than if that downtime didn't exist. I believe adding spinners wouldn't even evade the nerf because they give 0 strain and 0 strains are excluded from the calculation. As for the length scaling - sure I'll try making it scale with overall map length with a 30s minimum

@Givikap120
Copy link
Contributor

I don't think adding 30 seconds of low difficulty is invalidating the concept - objects after are still less retryable than if that downtime didn't exist. I believe adding spinners wouldn't even evade the nerf because they give 0 strain and 0 strains are excluded from the calculation. As for the length scaling - sure I'll try making it scale with overall map length with a 30s minimum

scaling with length may introduce stability issues where adding objects in the end of the map is dropping star rating

@tsunyoku
Copy link
Member

!diffcalc
RULESET=osu

@tsunyoku
Copy link
Member

let's try something..

@tsunyoku
Copy link
Member

!diffcalc
RULESET=osu
OSU_A=https://github.com/ppy/osu/tree/pp-dev
OSU_B=#31181

Copy link

@pull-request-size pull-request-size bot added size/M and removed size/S labels Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: In Progress
Development

Successfully merging this pull request may close these issues.

4 participants