This repository has been archived by the owner on Jul 21, 2024. It is now read-only.
feat: support multiple PR reviews #223
Merged
+458
−92
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Provide support for requiring multiple reviews. Add a "partially-approved" state, which occurs when the number of approvals is less than the required number (from branch protections) or the number of reviewers who have been requested but have not submitted an approval fixes pr-triage#194
Resolve incorrectly using the requested number of reviews. The value is not the total number of requested reviews, but the number of reviews remaining. Also, fix a commit issue where the `payload.json` fixture was not committed along with the tests
|
@allout58 Sorry not to replay quickly. I am gonna review your awesome work. Thanks a lot. |
sotayamashita
suggested changes
Mar 8, 2020
| const requiredReviews = | ||
| branchProtections.data.required_pull_request_reviews; | ||
| return ( | ||
| (requiredReviews && requiredReviews.required_approving_review_count) || 1 |
There was a problem hiding this comment.
Should it return 1 even if there is no required number of reviews? I would appreciate it if you could tell me the reason.
There was a problem hiding this comment.
This is a result of this comment on the original issue. Should be easy enough to change to zero, or in the future have some way of configuring the default.
sotayamashita
approved these changes
Mar 10, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Provide support for requiring multiple reviews. Add a "partially-approved" state, which occurs when
the number of approvals is less than the required number (from branch protections) or the number of
reviewers who have been requested but have not submitted an approval
(also includes the fix included in my PR #222, but actually from the CLI so it updates the required tests as well)
Fixes
fixes #194
New Permissions
Requires an update to the requested permissions: