agent-spawner: base64 encode the resalloc ticket DATA in env

[praiskup]

Fixes: #144

[siteshwar]

I have not tested these changes, but here are some general observations:

• Where is this variable named RESALLOC_RESOURCE_DATA?
• Where are RESOURCE_NAME, RESOURCE_POOL_ID etc. are set?
• Why RESALLOC_RESOURCE_DATA has to be base64 encoded? Is that because terminal output may contain binary characters?

[praiskup]

These are set here:

resalloc/resallocserver/manager.py

Lines 40 to 50 in 36a289d

	def command_env(pool_id=None, res_id=None, res_name=None,
	id_in_pool=None, data=None):
	pfx = 'RESALLOC_'
	env = os.environ.copy()
	env[pfx + 'ID'] = str(res_id)
	env[pfx + 'NAME'] = str(res_name)
	env[pfx + 'POOL_ID'] = str(pool_id)
	env[pfx + 'ID_IN_POOL'] = str(id_in_pool)
	if data is not None:
	env[pfx + 'RESOURCE_DATA'] = base64.b64encode(data)
	return env

Is that because terminal output may contain binary characters?

Yes.

[siteshwar]

These are set here:

Why they are not visible in the env output?

[praiskup]

They are actually. But resalloc != agent spawner.

[siteshwar]

They are actually. But resalloc != agent spawner.

Is this comment valid for agent spawner? If not, it should be removed and we should mention AGENT_SPAWNER_RESOURCE_DATA instead.

[praiskup]

Thank you for patiently punching me. You are right; the comment was wrong. I updated the docs, and fixed the fix.

Can you please take another look now?

[siteshwar]

Thank you for patiently punching me. You are right; the comment was wrong. I updated the docs, and fixed the fix.

Can you please take another look now?

LGTM. Although I have not tested these changes.

[siteshwar]

The only thing I may add is that base64 decoded data may contain new lines. It could be tricky to debug, if you are not familiar with functioning of resalloc. It kept me confused for a while.

[praiskup]

Indeed, the current code doesn't modify the stdout at all, and thus it contains the trailing newline. We could implement some RFE for stdout post-processing if you think it is worth it.