Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PgamSSP adapter : add GVL ID #3641

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

chicoman25
Copy link
Contributor

Merged changes from Go adapter: prebid/prebid-server#4056

% curl https://vendor-list.consensu.org/v3/vendor-list.json | jq '.vendors."1353"'
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
                                 Dload  Upload   Total   Spent    Left  Speed
100  652k  100  652k    0     0  2744k      0 --:--:-- --:--:-- --:--:-- 2753k
{
  "id": 1353,
  "name": "PGAM Media LLC",
  "purposes": [
    1,
    3,
    4,
    5,
    6,
    7,
    8,
    9,
    10
  ],
  "legIntPurposes": [],
  "flexiblePurposes": [],
  "specialPurposes": [
    3
  ],
  "features": [
    3
  ],
  "specialFeatures": [
    1
  ],
  "cookieMaxAgeSeconds": 1209600,
  "usesCookies": true,
  "cookieRefresh": true,
  "urls": [
    {
      "langId": "en",
      "privacy": "https://pgammedia.com/privacy-policy/",
      "legIntClaim": "https://pgammedia.com/privacy-policy/"
    }
  ],
  "usesNonCookieAccess": false,
  "dataRetention": {
    "stdRetention": 14,
    "purposes": {
      "8": 11
    },
    "specialPurposes": {
      "3": 30
    }
  },
  "dataDeclaration": [
    1,
    2,
    8
  ],
  "deviceStorageDisclosureUrl": "https://pgammedia.com/devicestorage.json"
}

@osulzhenko osulzhenko linked an issue Dec 18, 2024 that may be closed by this pull request
@@ -1,6 +1,7 @@
adapters:
pgamssp:
endpoint: http://us-east.pgammedia.com/pserver
gvlVendorID: 1353
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PBS Java uses different syntax. Should be vendor-id. It's already present in the yaml file, just set to 0 right now.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. I've made the adjustment to vendor-id and removed gvlVendorID

@Net-burst Net-burst changed the title add GVL ID to PgamSSP PgamSSP adapter : add GVL ID Dec 18, 2024
@Net-burst Net-burst requested a review from osulzhenko December 18, 2024 16:47
@CTMBNara CTMBNara merged commit 2a59c20 into prebid:master Dec 19, 2024
6 of 7 checks passed
sergseven pushed a commit to openx/prebid-server-java that referenced this pull request Dec 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port PR from PBS-Go: PgamSSP: Add GVL vendor ID
4 participants