Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Config Backwards Compatibility: Account GDPR/CCPA Integration Enabled #3155

Merged
merged 2 commits into from
Oct 3, 2023
Merged

Remove Config Backwards Compatibility: Account GDPR/CCPA Integration Enabled #3155

merged 2 commits into from
Oct 3, 2023

Conversation

bsardo
Copy link
Collaborator

@bsardo bsardo commented Sep 27, 2023

The upcoming 2.0 release will remove backwards compatibility for deprecated host and account configuration options. This PR removes support for the following account options:

  • ccpa.integration_enabled
  • gdpr.integration_enabled

Instead, hosts should use ccpa.channel_enabled and gdpr.channel_enabled respectively in account configs.
For example:

"gdpr": {
    "channel_enabled": {
      "web": true,
      "app": false,
      "dooh": true,
      "amp": false,
      "video": true
    }
}

AlexBVolcy
AlexBVolcy reviewed Sep 27, 2023
View reviewed changes
account/account.go Outdated
for _, purposeName := range deprecatedPurposeFields {
me.RecordAccountGDPRPurposeWarning(accountID, purposeName)
}
if len(deprecatedPurposeFields) > 0 || usingGDPRChannelEnabled || usingCCPAChannelEnabled {
if len(deprecatedPurposeFields) > 0 {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know that this line gets removed in another Remove Config PR, but it leaves me wondering if the RecordAccountUpgradeStatus metric should be removed as well?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 merged with master to resolve conflicts and removed RecordAccountUpgradeStatus in the process.

@bsardo bsardo merged commit a2e387f into prebid:master Oct 3, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexBVolcy AlexBVolcy AlexBVolcy approved these changes

@VeronikaSolovei9 VeronikaSolovei9 VeronikaSolovei9 approved these changes

Assignees

@VeronikaSolovei9 VeronikaSolovei9

@AlexBVolcy AlexBVolcy

Labels
do not port
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bsardo @VeronikaSolovei9 @AlexBVolcy