Adapter Name Case Insensitive: EID Permissions #3187
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SyntaxNode
commented
Oct 6, 2023
| @@ -103,6 +103,7 @@ func NewAmpEndpoint( | |||
| storedRespFetcher, | |||
| hookExecutionPlanBuilder, | |||
| tmaxAdjustments, | |||
| openrtb_ext.NormalizeBidderName, | |||
There was a problem hiding this comment.
Sorry. I hate to add yet another parameter here, but I can't test it properly otherwise.
| @@ -765,7 +769,7 @@ func (deps *endpointDeps) validateRequest(req *openrtb_ext.RequestWrapper, isAmp | |||
| } | |||
| } | |||
|
|
|||
| var aliases map[string]string | |||
| var requestAliases map[string]string | |||
There was a problem hiding this comment.
Making clear these are request aliases, not hardcoded aliases. Request alias names are still case sensitive.
| knownBidders: map[string]openrtb_ext.BidderName{"a": openrtb_ext.BidderName("a")}, | ||
| knownAliases: map[string]string{"c": "c"}, | ||
| expectedError: errors.New(`unrecognized bidder "A"`), | ||
| }, |
There was a problem hiding this comment.
Test case is no longer valid.
| { | ||
| "id": "id1" | ||
| } | ||
| ] |
There was a problem hiding this comment.
Doesn't really matter for these tests, but the eids structure was wrong.
onkarvhanumante
approved these changes
Oct 6, 2023
VeronikaSolovei9
approved these changes
Oct 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discovered there is still work needed after manually validating #3141