-
Notifications
You must be signed in to change notification settings - Fork 753
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New Adapter: TradPlus #3838
New Adapter: TradPlus #3838
Conversation
Code coverage summaryNote:
tradplusRefer here for heat map coverage report
|
return nil, errs | ||
} | ||
|
||
tradplusExt, err := getImpressionExt(&request.Imp[0]) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tradplus Can you please confirm if you want to use ext of first impression even in case of multiple imps? If that is the case then validateTradPlusExt()
function can be only used for first imp rather than looping over all the imps or validation for accountId can be done in getImpressionExt()
function itself and return error from getImpressionExt()
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the validateTradPlusExt
method has been deleted.
PR is inactive for more than 3-4 weeks. Therefore, closing this PR. @tradplus, reopen this PR after addressing open comments or making code changes. |
Sorry for the delayed reply, the issue has been fixed, please reopen this PR. |
@tradplus Also please take a look on Java implementation |
Already modified. |
A PR has been recreated:#3987 |
TradPlus is a leading, stable, and reliable ad monetization platform that is committed to providing global developers with fair, transparent and efficient monetization solutions. We also provide ADX and Saas ADX services. We serve 2,000+ global developers. Moreover, Our SDK has been certified by IAB Tech Lab and also joins Google Play SDK Index. And we have Information Security Management Certification.
Our advertising business spans the world. This is our official website: https://tradplusad.com/en. You can get more details about TradPlus.
this is TradPlus adapter version 1.0.
Thank!