Pubmatic: Forward displaymanager and displaymanagerver from app ext #4000
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
SyntaxNode
changed the title
SyntaxNode
reviewed
Oct 21, 2024
There was a problem hiding this comment.
Coded unit tests are fine, but we look at the json test coverage since that includes additional assertions for memory safety. Please add json tests to cover this change.
There was a problem hiding this comment.
Updated the test cases.
There was a problem hiding this comment.
@SyntaxNode Can you please review the latest changes?
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
|
@SyntaxNode Can you please review and merge the latest changes? |
przemkaczmarek
previously approved these changes
Nov 22, 2024
|
Hi @bsardo / @SyntaxNode Can you please review and merge this PR? Thanks |
bsardo
reviewed
Dec 3, 2024
Comment on lines
+678
to
+682
| if source, err := jsonparser.GetString(app.Ext, "source"); err == nil && source != "" { | ||
| if version, err := jsonparser.GetString(app.Ext, "version"); err == nil && version != "" { | ||
| return source, version | ||
| } | ||
| } |
There was a problem hiding this comment.
As mentioned earlier here, you're missing JSON test coverage.
Please add another display manager JSON test where the source and version are present at app.ext but not at app.ext.prebid to cover these lines.
| return source, version | ||
| } | ||
| } | ||
| return "", "" |
There was a problem hiding this comment.
As mentioned earlier here, you're missing JSON test coverage. Please either add a new JSON test or modify an existing JSON test so app.ext is present but without source or version being set so this default case is covered.
adapters/pubmatic/pubmatic_test.go
Outdated
| want want | ||
| }{ | ||
| { | ||
| name: "request app object is not nil but app.ext has no source and version", |
There was a problem hiding this comment.
Please update the name strings throughout this test substituting dashes or underscores for spaces. t.Run does this automatically so doing this in the tests makes it easy to search for failed tests in the code base.
e.g. name: "request-app-object-is-not-nil-but-app.ext-has-no-source-and-version"
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
|
@bsardo @SyntaxNode, Addressed review comments please review. |
Code coverage summaryNote:
pubmaticRefer here for heat map coverage report |
przemkaczmarek
approved these changes
Dec 4, 2024
bsardo
approved these changes
Dec 4, 2024
bsardo
changed the title
scr-oath
pushed a commit
to scr-oath/prebid-server
that referenced
this pull request
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.