-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: use iarna/toml instead of toml #118
fix: use iarna/toml instead of toml #118
Conversation
You need to add this library to the tsup config |
I think we should also wrap the readfile and parse toml in a try catch and do core.error if we catch something Line 211 in b684872
The issue was a bit annoying to spot right now. |
Is an |
I would add core.error("failed to parse pyproject.toml") and then throw the error again s.t. we see where this error was thrown. The previous error message (https://discord.com/channels/1082332781146800168/1082338253925003385/1245052133053829182) was not really helpful All errors are catched and displayed in the outer most run action part |
Yeah right! will do. |
Haha @pavelzw this is why I wanted a |
Or should we updated to And should I make a patch release? |
Let’s use pnpm 9 and a patch release 👍🏻 |
Using a better toml parser: https://shared.by.re-becca.org/misc/TOML-SPEC-SUPPORT.html
Fixes a known issue were the following table doesn't work but is valid toml: