forked from airlift/drift
-
Notifications
You must be signed in to change notification settings - Fork 27
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Netty Version Upgrade to 4.1.115.Final for Drift #54
Open
imsayari404
wants to merge
1
commit into
prestodb:master
Choose a base branch
from
imsayari404:netty_common
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Upgraded `dep.netty.version` to 4.1.115.Final to include the latest fixes and improvements.
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 6, 2024
drift repo pr to update netty:(prestodb/drift#54)
imsayari404
force-pushed
the
netty_common
branch
from
December 6, 2024 12:41
644b05e
to
09665c9
Compare
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 6, 2024
drift repo pr to update netty:(prestodb/drift#54)
|
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 7, 2024
…ch 1 drift repo pr to update netty:(prestodb/drift#54)
imsayari404
force-pushed
the
netty_common
branch
from
December 7, 2024 11:56
67bf811
to
deabf7d
Compare
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 7, 2024
prestodb/drift pr : prestodb/drift#54
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 7, 2024
prestodb/drift pr : prestodb/drift#54
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 9, 2024
prestodb/drift pr : prestodb/drift#54
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 9, 2024
prestodb/drift pr : prestodb/drift#54
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 9, 2024
prestodb/drift pr : prestodb/drift#54
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 9, 2024
prestodb/drift pr : prestodb/drift#54
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 9, 2024
prestodb/drift pr : prestodb/drift#54
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 9, 2024
prestodb/drift pr : prestodb/drift#54
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 11, 2024
prestodb/drift pr : prestodb/drift#54
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 20, 2024
-prestodb/drift pr : prestodb/drift#54 -Resolved presto-druid module error -Resolving issues related to maven checks -Ignored Specific duplicate resouces explicitly related to com/github/rvesse/airline/core.version -Fix: Replace deprecated io.netty:netty with io.netty:netty-all version 4.1.115.Final
imsayari404
added a commit
to imsayari404/presto
that referenced
this pull request
Dec 20, 2024
-prestodb/drift pr : prestodb/drift#54 -Resolved presto-druid module error -Resolving issues related to maven checks -Ignored Specific duplicate resouces explicitly related to com/github/rvesse/airline/core.version -Fix: Replace deprecated io.netty:netty with io.netty:netty-all version 4.1.115.Final
agrawalreetika
approved these changes
Dec 20, 2024
imjalpreet
reviewed
Dec 20, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we already have a draft presto PR that triggered the CI pipeline using JitPack dependency? If yes, can you also add the link to the draft PR here for reference?
ZacBlanco
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR upgrades the
Netty
version to4.1.115.Final
and publishes the custom JAR to JitPack for the Drift project. The following changes were made:Updated the
Netty version
in the pom.xml file to4.1.115.Final
.(link)Draft pr raised in prestodb/presto : [DNR] Upgraded version : io.netty:netty-common:4.1.115.Final presto#24175
This upgrade ensures that we are using a more stable and secure version of Netty, addressing potential vulnerabilities in the previous version.
I ran mvn clean install, and the build was successful. CI tests will be triggered to validate these changes in the Presto draft PR with the updated Drift version.