-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor/201 쪽지 상세조회시 읽음처리 기능 추가 #202
Conversation
- Note 엔티티에 isRead 업데이트 기능 구현 - 기존 쪽지 상세조회 로직에 isRead 업데이트 기능 추가
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
말씀드린것만 수정부탁드립니다~
Note note = getNote(noteId); | ||
|
||
note.markAsRead(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
이거 일단은 QueryService 라 transactional read true 일텐데
레포지토리로 .save 해주면 좋을것 같아요.
Note note = getNote(noteId); | ||
|
||
note.markAsRead(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
여기도요!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
감사합니다 큰 실수를 할 뻔했습니다
책임의 분리가 확실하지 않다고 생각해서 읽음처리에 대한 유스케이스와 구현체를 따로 구현하도록 리팩토링 했습니다
- 읽음 처리를 위한 유스케이스 추가 - 읽음 처리 유스케이스 구현체 추가 - 테스트 코드 검증및 구현
- noteId를 고정값이 아닌 생성된 쪽지의 id를 사용하도록 수정
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
수고하셨습니다!
Quality Gate passedIssues Measures |
📌 과제 설명
쪽지 상세조회시 읽음처리 기능 추가
👩💻 요구 사항과 구현 내용
✅ PR 포인트 & 궁금한 점