Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor/201 쪽지 상세조회시 읽음처리 기능 추가 #202

Merged
merged 3 commits into from
Dec 8, 2024

Conversation

7zrv
Copy link
Collaborator

@7zrv 7zrv commented Dec 8, 2024

📌 과제 설명

쪽지 상세조회시 읽음처리 기능 추가

👩‍💻 요구 사항과 구현 내용

  • Note 엔티티에 isRead 업데이트 기능 구현
  • 기존 쪽지 상세조회 로직에 isRead 업데이트 기능 추가

✅ PR 포인트 & 궁금한 점

- Note 엔티티에 isRead 업데이트 기능 구현
- 기존 쪽지 상세조회 로직에 isRead 업데이트 기능 추가
@7zrv 7zrv self-assigned this Dec 8, 2024
@7zrv 7zrv linked an issue Dec 8, 2024 that may be closed by this pull request
3 tasks
Copy link
Collaborator

@ayoung-dev ayoung-dev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good!

Copy link
Collaborator

@leebs0521 leebs0521 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

말씀드린것만 수정부탁드립니다~

Note note = getNote(noteId);

note.markAsRead();

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

이거 일단은 QueryService 라 transactional read true 일텐데
레포지토리로 .save 해주면 좋을것 같아요.

Note note = getNote(noteId);

note.markAsRead();

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

여기도요!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

감사합니다 큰 실수를 할 뻔했습니다
책임의 분리가 확실하지 않다고 생각해서 읽음처리에 대한 유스케이스와 구현체를 따로 구현하도록 리팩토링 했습니다

- 읽음 처리를 위한 유스케이스 추가
- 읽음 처리 유스케이스 구현체 추가
- 테스트 코드 검증및 구현
github-actions[bot]

This comment was marked as resolved.

@github-actions github-actions bot changed the title Refactor/201 쪽지 상세조회시 읽음처리 기능 추가 [BUILD FAIL] Refactor/201 쪽지 상세조회시 읽음처리 기능 추가 Dec 8, 2024
@github-actions github-actions bot closed this Dec 8, 2024
- noteId를 고정값이 아닌 생성된 쪽지의 id를 사용하도록 수정
@7zrv 7zrv reopened this Dec 8, 2024
@7zrv 7zrv changed the title [BUILD FAIL] Refactor/201 쪽지 상세조회시 읽음처리 기능 추가 Refactor/201 쪽지 상세조회시 읽음처리 기능 추가 Dec 8, 2024
Copy link
Collaborator

@m-a-king m-a-king left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

수고하셨습니다!

@7zrv 7zrv merged commit fdd7420 into main Dec 8, 2024
4 checks passed
@7zrv 7zrv deleted the refactor/201-modify-add-update-read-status branch December 8, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[REFACTOR]쪽지 상세 조회시 읽음 처리로 상태를 전환하는 기능 추가
4 participants