Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Site refactor] Update Testimonial documentation #438

Merged
merged 2 commits into from
Oct 5, 2023

Conversation

josepmartins
Copy link
Contributor

@josepmartins josepmartins commented Oct 2, 2023

Summary

Updates the design guidelines regarding the site refactor new UI and layout adjustments

Fixes: https://github.com/github/primer/issues/2706
Part of: https://github.com/github/primer/issues/2620

List of notable changes:

  • updated images in Testimonial design guidelines
  • added emphasis usage examples

What should reviewers focus on?

Design guidelines: https://primer-1543f44201-26139705.drafts.github.io/components/Testimonial

Supporting resources (related issues, external links, etc):

Contributor checklist:

  • All new and existing CI checks pass
  • Tests prove that the feature works and covers both happy and unhappy paths
  • Any drop in coverage, breaking changes or regressions have been documented above
  • New visual snapshots have been generated / updated for any UI changes
  • All developer debugging and non-functional logging has been removed
  • Related issues have been referenced in the PR description

Reviewer checklist:

  • Check that pull request and proposed changes adhere to our contribution guidelines and code of conduct
  • Check that tests prove the feature works and covers both happy and unhappy paths
  • Check that there aren't other open Pull Requests for the same update/change

Screenshots:

Please try to provide before and after screenshots or videos

Before After

@josepmartins josepmartins self-assigned this Oct 2, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 2, 2023

⚠️ No Changeset found

Latest commit: 7582fb2

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

🟢 No design token changes found

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

⚠️ Visual differences found

Our visual comparison tests found UI differences.

Please review the differences by using the test artifacts to ensure that the changes were intentional.

Artifacts can be downloaded and reviewed locally.

Download links are available at the bottom of the workflow summary screen.

Example:

artifacts section of workflow run

If the changes are expected, please run npm run test:visual:update-snapshots to replace the previous fixtures.

Review visual differences

Copy link
Collaborator

@rezrah rezrah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 LGTM

@josepmartins josepmartins changed the title Update Testimonial documentation [Site refactor] Update Testimonial documentation Oct 4, 2023
@josepmartins josepmartins merged commit 2dd0109 into main Oct 5, 2023
13 of 15 checks passed
@josepmartins josepmartins deleted the josepmartins/testimonial-docs-update branch October 5, 2023 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants