-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix VideoPlayer accessibility issues #703
Conversation
🦋 Changeset detectedLatest commit: 7aeb162 The changes in this PR will be included in the next version bump. This PR includes changesets to release 6 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
🔍 Design token changes foundView CSS variable changes- --brand-videoPlayer-title-bgColor: linear-gradient(#01040966, var(--base-color-scale-transparent));
+ --brand-videoPlayer-title-bgColor: linear-gradient(180deg, #000000e6, #00000073 66%, transparent); - --brand-videoPlayer-controls-bgColor: linear-gradient(var(--base-color-scale-transparent), #01040966);
+ --brand-videoPlayer-controls-bgColor: #000000bf; - --brand-videoPlayer-range-bgColor-progress: var(--base-color-scale-blue-5);
+ --brand-videoPlayer-range-bgColor-progress: var(--base-color-scale-blue-4); - --brand-videoPlayer-title-bgColor: linear-gradient(#01040966, var(--base-color-scale-transparent));
+ --brand-videoPlayer-title-bgColor: linear-gradient(180deg, #000000e6, #00000073 66%, transparent); - --brand-videoPlayer-controls-bgColor: linear-gradient(var(--base-color-scale-transparent), #01040966);
+ --brand-videoPlayer-controls-bgColor: #000000bf; - --brand-videoPlayer-range-bgColor-progress: var(--base-color-scale-blue-5);
+ --brand-videoPlayer-range-bgColor-progress: var(--base-color-scale-blue-4); |
🟢 No visual differences foundOur visual comparison tests did not find any differences in the UI. |
...ual.spec.ts-snapshots/Visual-Comparison-VideoPlayer-VideoPlayer-Custom-Play-Icon-1-linux.png
Outdated
Show resolved
Hide resolved
9beb0d8
to
f1953af
Compare
c79c3aa
to
5ed8496
Compare
packages/design-tokens/src/tokens/functional/components/video-player/colors.js
Outdated
Show resolved
Hide resolved
...r.visual.spec.ts-snapshots/Visual-Comparison-VideoPlayer-VideoPlayer-With-Poster-1-linux.png
Outdated
Show resolved
Hide resolved
528ef06
to
05a24e4
Compare
05a24e4
to
d5fc0a4
Compare
d5fc0a4
to
5fe8759
Compare
52dfae2
to
7aeb162
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's looking great, thanks @joshfarrant.
Something that would be nice to look at in a follow-up is the position of captions. It's quite high at the moment due to the controls bar offset.
Summary
Fixes two Sev-2
VideoPlayer
a11y issues.The styling of the controls bar is heavier than it was before, but it's necessary to achieve the required contrast.
List of notable changes:
VideoPlayer
focus styles by making the focus outline thicker and offsetting it.VideoPlayer
, or after a few seconds of inactivity, and reappears when the cursor or focus returns.Steps to test:
VideoPlayer
with the keyboardSupporting resources (related issues, external links, etc):
Contributor checklist:
Reviewer checklist:
Screenshots: