Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Radio): Remove CSS modules feature flag from Radio #5463

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore(Radio): Remove CSS modules feature flag from Radio #5463

wants to merge 3 commits into from

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Dec 18, 2024 •
edited
Loading

Changelog

New

Changed

Removed

Remove CSS modules feature flag from Radio

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Dec 18, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: c86476c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 18, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-5463 December 18, 2024 23:43 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Dec 18, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.12 KB (-0.27% 🔽)
packages/react/dist/browser.umd.js 104.53 KB (-0.18% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5463 December 19, 2024 18:54 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/356019

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Dec 19, 2024
@jonrohan jonrohan marked this pull request as ready for review December 19, 2024 22:47
@jonrohan jonrohan requested a review from a team as a code owner December 19, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hussam-i-am hussam-i-am hussam-i-am approved these changes

@francinelucca francinelucca Awaiting requested review from francinelucca francinelucca is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @hussam-i-am