-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(query-engine): use @map
'd values of enum
in query input and output
#4987
Conversation
CodSpeed Performance ReportMerging #4987 will not alter performanceComparing Summary
|
WASM Query Engine file Size
|
…isma-engines into integration/enum-mapped-values
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you please add some tests where you pass a mapped value in a query (or point me to the existing tests)? I assume GraphQL protocol will probably break for enums with numeric values or special characters like /
in your languages example.
Co-authored-by: Alexey Orlenko <[email protected]>
…isma-engines into integration/enum-mapped-values
Right, I've added the new |
Updates after some investigation with @aqrln:
|
This PR contributes to prisma/prisma#8446.
This PR introduces a breaking change, let's wait for Prisma 6.
With this PR:
ba87944 can be extracted into its own PR, as it fixes a
prisma validate
bug internally discovered here.