Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(psl): GA fullTextIndex and fullTextSearch for provider = "mysql" #5031

Closed
wants to merge 12 commits into from

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Oct 31, 2024

This PR:

Context: Docs.


We're only GA-ing fullTextSearch for provider = "mysql", but psl_core::common::preview_features::FeatureMap has no knowledge of which Prisma database provider is currently selected by the user.

Hence, I've introduced psl_core::common::preview_features::FeatureMapWithProvider::<'a>, which, given a provider, exposes the same functionality as the old FeatureMap, but allows for escape hatches when provider = "mysql".
FeatureMap is now a private struct.

I've added new validation tests to detect the different preview feature validation logic for fullTextSearch on provider = "mysql" vs provider = "postgresql". I've also removed deprecated tests for fullTextIndex.

In 8ce72a2, I've added a default implementation of FeatureMapWithProvider as a convenience for https://github.com/prisma/language-tools. Implication: the autocompletion on generator's previewFeatures' array will include "fullTextSearch" on "mysql", even though adding it would trigger a warning when running the prisma validate command.

* fix(schema): fix type clash for generated relation filter

* chore(dmmf): update snapshots

* chore(prisma-fmt): update snapshots
@jkomyno jkomyno requested a review from a team as a code owner October 31, 2024 12:49
@jkomyno jkomyno requested review from wmadden and removed request for a team October 31, 2024 12:49
Copy link
Contributor

github-actions bot commented Oct 31, 2024

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.038MiB 2.038MiB 853.000B
Postgres (gzip) 818.975KiB 818.838KiB 140.000B
Mysql 2.002MiB 2.001MiB 844.000B
Mysql (gzip) 804.788KiB 804.592KiB 200.000B
Sqlite 1.901MiB 1.900MiB 853.000B
Sqlite (gzip) 765.307KiB 765.012KiB 302.000B

Copy link

codspeed-hq bot commented Oct 31, 2024

CodSpeed Performance Report

Merging #5031 will not alter performance

Comparing feat/ga-mysql-fulltextsearch-fulltextindex (027c45e) with main (5b155e0)

Summary

✅ 11 untouched benchmarks

@jkomyno jkomyno changed the base branch from main to integration/next October 31, 2024 14:06
@jkomyno jkomyno force-pushed the feat/ga-mysql-fulltextsearch-fulltextindex branch from b1526d5 to f74a000 Compare October 31, 2024 14:40
@jkomyno jkomyno force-pushed the feat/ga-mysql-fulltextsearch-fulltextindex branch from f74a000 to 455e43e Compare October 31, 2024 14:41
@jkomyno jkomyno requested review from aqrln and removed request for wmadden October 31, 2024 14:42
@jkomyno jkomyno added this to the 6.0.0 milestone Oct 31, 2024
Base automatically changed from integration/next to main November 15, 2024 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant