-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(psl): GA fullTextIndex
and fullTextSearch
for provider = "mysql"
#5031
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(schema): fix type clash for generated relation filter * chore(dmmf): update snapshots * chore(prisma-fmt): update snapshots
jkomyno
commented
Oct 31, 2024
WASM Query Engine file Size
|
CodSpeed Performance ReportMerging #5031 will not alter performanceComparing Summary
|
jkomyno
force-pushed
the
feat/ga-mysql-fulltextsearch-fulltextindex
branch
from
October 31, 2024 14:40
b1526d5
to
f74a000
Compare
…oduced "FeatureMapWithProvider"
…r prisma/language-tools
jkomyno
force-pushed
the
feat/ga-mysql-fulltextsearch-fulltextindex
branch
from
October 31, 2024 14:41
f74a000
to
455e43e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Context: Docs.
We're only GA-ing
fullTextSearch
forprovider = "mysql"
, butpsl_core::common::preview_features::FeatureMap
has no knowledge of which Prisma database provider is currently selected by the user.Hence, I've introduced
psl_core::common::preview_features::FeatureMapWithProvider::<'a>
, which, given aprovider
, exposes the same functionality as the oldFeatureMap
, but allows for escape hatches whenprovider = "mysql"
.FeatureMap
is now a private struct.I've added new validation tests to detect the different preview feature validation logic for
fullTextSearch
onprovider = "mysql"
vsprovider = "postgresql"
. I've also removed deprecated tests forfullTextIndex
.In 8ce72a2, I've added a default implementation of
FeatureMapWithProvider
as a convenience for https://github.com/prisma/language-tools. Implication: the autocompletion ongenerator
'spreviewFeatures
' array will include"fullTextSearch"
on"mysql"
, even though adding it would trigger a warning when running theprisma validate
command.