Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(psl): add "async", "await", "using" to the list of reserved words #5058

Merged
merged 1 commit into from
Nov 28, 2024

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Nov 28, 2024

This PR:


TODO(jkomyno): follow-up by adding the same words to the denylist in prisma/prisma: prisma/prisma#25748

@jkomyno jkomyno added this to the 6.0.0 milestone Nov 28, 2024
@jkomyno jkomyno requested a review from a team as a code owner November 28, 2024 11:04
@jkomyno jkomyno requested review from jacek-prisma and aqrln and removed request for a team and jacek-prisma November 28, 2024 11:04
Copy link

codspeed-hq bot commented Nov 28, 2024

CodSpeed Performance Report

Merging #5058 will not alter performance

Comparing feat/psl-reserved-words (8520863) with main (0160cc2)

Summary

✅ 11 untouched benchmarks

Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.049MiB 2.049MiB 40.000B
Postgres (gzip) 821.939KiB 821.958KiB -19.000B
Mysql 2.013MiB 2.013MiB 40.000B
Mysql (gzip) 807.916KiB 807.708KiB 213.000B
Sqlite 1.910MiB 1.910MiB 40.000B
Sqlite (gzip) 768.140KiB 768.141KiB -1.000B

@jkomyno jkomyno merged commit 1886abc into main Nov 28, 2024
367 checks passed
@jkomyno jkomyno deleted the feat/psl-reserved-words branch November 28, 2024 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants