Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: typo in migrations_lock.toml #5085

Merged
merged 1 commit into from
Dec 16, 2024
Merged

chore: typo in migrations_lock.toml #5085

merged 1 commit into from
Dec 16, 2024

Conversation

jkomyno
Copy link
Contributor

@jkomyno jkomyno commented Dec 16, 2024

This PR closes prisma/prisma#25855.

@jkomyno jkomyno requested a review from a team as a code owner December 16, 2024 11:18
@jkomyno jkomyno requested review from aqrln and removed request for a team December 16, 2024 11:18
@jkomyno jkomyno added this to the 6.1.0 milestone Dec 16, 2024
Copy link
Contributor

WASM Query Engine file Size

Engine This PR Base branch Diff
Postgres 2.078MiB 2.078MiB 0.000B
Postgres (gzip) 835.072KiB 835.073KiB -1.000B
Mysql 2.044MiB 2.044MiB 0.000B
Mysql (gzip) 821.528KiB 821.530KiB -2.000B
Sqlite 1.942MiB 1.942MiB 0.000B
Sqlite (gzip) 781.036KiB 781.036KiB 0.000B

Copy link

codspeed-hq bot commented Dec 16, 2024

CodSpeed Performance Report

Merging #5085 will not alter performance

Comparing fix/typo-migration-lock (5ce44e2) with main (5b4fe75)

Summary

✅ 11 untouched benchmarks

Copy link
Member

@aqrln aqrln left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reminds me that I wanted to give Jujutsu a try 😄

@aqrln
Copy link
Member

aqrln commented Dec 16, 2024

Since we're having a pedantry contest here in this PR and the linked issue, I feel like it's not necessarily a typo but possibly a deliberate choice of wording. To me the original sentence has a bit different tone and reads as "It should be added to your version control system, and if you don't know what version control system means, it means Git", in contrast with the new wording which reads as "It should be added to whatever version control system you use, Git or otherwise". But I agree that the new wording is better.

@jkomyno jkomyno merged commit 199ce40 into main Dec 16, 2024
367 checks passed
@jkomyno jkomyno deleted the fix/typo-migration-lock branch December 16, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use of "i.e." instead of "e.g." in migration_lock.toml
3 participants