Add support for lists of tactics #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eddie Knight <[email protected]>
Signed-off-by: Eddie Knight <[email protected]>
krumware
previously approved these changes
Oct 18, 2023
eddie-knight
dismissed
krumware’s stale review
The merge-base changed after approval.
krumware
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follows #3.
The config may now stipulate a single
tacticstring or a list of strings intactics. Tactics will supersede tactic.Output will now be sorted according to the tactic used:
If a strike falls under multiple tactics, the
ControlIDfor the active tactic will be logged.Enabling this required moving quite a bit of logic out of the wireframe to keep everything cohesive— so that's a side benefit. Previous versions of the wireframe will break with this change.