-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update devcontainer config to support Foxglove Studio on Codespace #110
Draft
mjyc
wants to merge
69
commits into
prl-mushr:master
Choose a base branch
from
mjyc:noetic-codespace
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Drop xacro arg that became default to silence a warning Bump CMake version to avoid a warning
Neither meshes nor xacro sources were being put into the installed robots directory. Looks like typos
Pretty gross, so will eventually need to refactor to avoid repeating same command and increasing surface area for copy paste bugs
…ic-docker-cmd-update
Add new foxglove layout preset
Noetic bashscript updates
Noetic build fixes
made install changes for OSX, removed python2 for CPU
mjyc
changed the title
Noetic codespace
Update devcontainer setup to support Codespace + Foxglove
Jun 7, 2023
mjyc
changed the title
Update devcontainer setup to support Codespace + Foxglove
Update devcontainer config to support Foxglove Studio on Codespace
Jun 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Status
Blocked on
Description
Updates foxglove studio installation & launch scripts to enable using foxglove studio app hosted in a codespace instance. See this demo video or this parent discussion.
Notes
2023/06/07 Things to know about the demo video: (1) I prebuilt the codespace instance to save the initial build time for the video. (2) To get the demo working, I made the change shown in prl-mushr/mushr_sim#20 on the codespace instance. (3) The self-hosted foxglove studio web app does not allow loading a layout file (e.g., see this related thread in foxglove slack). There are workarounds (e.g., mentioned in the thread), but I propose to wait for the proper fix as foxglove team is working on fixing this issue (I think--reminder: add a related tick if I find one).
Steps to Test
Follow these steps to set up Mushr in codespace and access the self-hosted foxglove studio:
https://github.com/mjyc/mushr
, click the Code drop-down menu.noetic-codespace
.Acknowledgement
I thank Ruffin who solved various tricky problems to get Codespace + Foxglove working. For details, see https://discourse.ros.org/t/repeatable-reproducible-and-now-accessible-ros-development-via-dev-containers/31398