Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor diffeq to pylint #694

Merged
merged 16 commits into from
Apr 5, 2022
Merged

refactor diffeq to pylint #694

merged 16 commits into from
Apr 5, 2022

Conversation

akapoor13
Copy link
Contributor

@akapoor13 akapoor13 commented Mar 30, 2022

In a Nutshell

Fix pylint messages in probnum.diffeq

Detailed Description

Refactors probnum.diffeq to comply with pylint line-too-long, no-else-return and no-else-raise.

Related Issues

Closes #669

@akapoor13 akapoor13 requested review from pnkraemer, schmidtjonathan and a team as code owners March 30, 2022 06:21
@codecov
Copy link

codecov bot commented Mar 30, 2022

Codecov Report

Merging #694 (2d04a55) into main (32299e6) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #694   +/-   ##
=======================================
  Coverage   89.93%   89.93%           
=======================================
  Files         192      192           
  Lines        7315     7315           
  Branches     1157     1157           
=======================================
  Hits         6579     6579           
  Misses        491      491           
  Partials      245      245           
Impacted Files Coverage Δ
src/probnum/diffeq/odefilter/_odefilter.py 97.67% <ø> (ø)
...rc/probnum/diffeq/odefilter/_odefilter_solution.py 90.62% <ø> (ø)
...ormation_operators/_approx_information_operator.py 91.30% <ø> (ø)
...probnum/diffeq/odefilter/init_routines/__init__.py 100.00% <ø> (ø)
...c/probnum/diffeq/odefilter/utils/_problem_utils.py 100.00% <ø> (ø)
...q/perturbed/scipy_wrapper/_wrapped_scipy_solver.py 100.00% <ø> (ø)
...bnum/diffeq/perturbed/step/_perturbedstepsolver.py 100.00% <ø> (ø)
...ter/information_operators/_information_operator.py 100.00% <100.00%> (ø)
...m/diffeq/perturbed/step/_perturbation_functions.py 89.47% <100.00%> (ø)
...um/diffeq/perturbed/step/_perturbedstepsolution.py 100.00% <100.00%> (ø)

@pnkraemer pnkraemer self-assigned this Mar 31, 2022
z(t + \Delta t) \sim \mathcal{N}(\mathbb{E}[\hat{z}(t + \Delta t)],
\mathbb{C}[\hat{z}(t + \Delta t)] + H \Phi(\Delta t) P(t) \Phi(\Delta t)^\top H^\top ),
z(t + \Delta t) \sim \mathcal{N}(\mathbb{E}[\hat{z}(t + \Delta t)],
\mathbb{C}[\hat{z}(t+\Delta t)]+H\Phi(\Delta t)P(t)\Phi(\Delta t)^\topH^\top),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could the \topH be the reason for the failed doc-build? It seems to me that this is not valid latex.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch, i compiled the latex code in Overleaf and realized the spacing would augment the formula

@akapoor13 akapoor13 requested a review from pnkraemer March 31, 2022 17:12
Copy link
Collaborator

@pnkraemer pnkraemer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of this!

@pnkraemer pnkraemer merged commit 9b78ca1 into probabilistic-numerics:main Apr 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Easy-to-fix pylint issues in probnum.diffeq
2 participants