Add deadlock regression test #61
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dennis-tra
force-pushed
the
issue-48-deadlock-test
branch
from
24941bc to
de889e4
Compare
dennis-tra
force-pushed
the
issue-48-deadlock-test
branch
from
de889e4 to
1ed1cca
Compare
|
I copied everything except the tracing changes into #63 |
dennis-tra
force-pushed
the
issue-48-deadlock-test
branch
from
2f37908 to
c0f91ca
Compare
dennis-tra
commented
Oct 13, 2023
| default: | ||
| } | ||
| close(w.monitor.NotifyFinished()) | ||
| close(finishedChan) |
There was a problem hiding this comment.
needed to change this, because BeforeFinished was called twice here.
dennis-tra
commented
Oct 13, 2023
| @@ -275,7 +274,6 @@ func (ts *QueryBehaviourBaseTestSuite) TestNotifiesQueryFinished() { | |||
| } | |||
|
|
|||
| func TestPooledQuery_deadlock_regression(t *testing.T) { | |||
| t.Skip() | |||
There was a problem hiding this comment.
uncommented this test
iand
reviewed
Oct 16, 2023
| require.IsType(t, &EventOutboundSendMessage{}, ev) | ||
| ev, _ = c.queryBehaviour.Perform(ctx) |
There was a problem hiding this comment.
Best to use DrainBehaviour from #64 here. We just want to run the behaviour until it has completed all its work. Future changes might introduce new events that would affect this test.
iand
approved these changes
Oct 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to #57