Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing std::result_of with decltype #81

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andrevis
Copy link

result_of and its helper type result_of_t are deprecated as of C++17

result_of and its helper type result_of_t are deprecated as of C++17
@andrevis andrevis closed this Sep 18, 2020
@fogti
Copy link

fogti commented Sep 19, 2020

Did the implementation work? Does it work even with C++11, or is there something preventing that? If it does in fact work with C++11, I would merge it into my fork.

@andrevis
Copy link
Author

Did the implementation work? Does it work even with C++11, or is there something preventing that? If it does in fact work with C++11, I would merge it into my fork.

Yes, it is. It seems ok with C++11 too. Here is a short demo (check C++11 in options):
http://cpp.sh/4rsyb

@andrevis andrevis reopened this Sep 21, 2020
@fogti
Copy link

fogti commented Sep 26, 2020

I merged the concept into my fork in commit fogti/ThreadPool@b7d0acb. I don't think this PR itself is going to be merged bc the repository seems to be abandoned since the beginning of 2015.

@Qix-
Copy link

Qix- commented Apr 18, 2022

For anyone looking for a C++17 fix for this that doesn't use decltype (which didn't work in all cases for me), check this commit: Qix-@113efd5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants