Forceful deletion of remaining pods after cleanup #670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…re not cleared when MCAD deletes the generic items after preemption
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue link
#599
What changes have been made
This version of the code allows users to provide a termination time that MCAD will use to wait before it forcefully deletes any remaining pods in the system. A cleanup is done first like it has always been done, but if there are still pods left after the wait time, they are forcefully deleted.
Verification steps
Ran code with AppWrapped pods that have a long
terminationGracePeriodSecondsand triggered preemption by deleting one of the pods sominAvailableis violated. Before requeuing, this version deletes ALL pods that are not cleaned up.Checks