Fix upside-down and vertical effect misalignment issues. #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kblaschke
force-pushed
the
bugfix/issue-725-fix-upside-down-issue
branch
from
0d2ac56 to
d1a0015
Compare
If anyone else can come up with a solution that doesn't involve up to three vertical flips, please implement.
kblaschke
force-pushed
the
bugfix/issue-725-fix-upside-down-issue
branch
from
d1a0015 to
116de57
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #725. Finally managed to make all effects and shaders align properly while not messing up the fragile u/v coordinates in the warp shader.
If anyone else can come up with a solution that doesn't involve up to three vertical flips, please implement your solution.