Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add VCPKG port #767

Closed

Conversation

Blaquewithaq
Copy link
Contributor

This pull request introduces VCPKG packaging for the ProjectM library. This enhancement allows users to easily install the library through VCPKG, enabling its integration into CMake projects on the Windows platform.

Questions

  • What do we want the library name to be within VCPKG? I've used libprojectm for now, but we could change it to what's preferred.

Let me know what changes you guys want if any!

@Blaquewithaq Blaquewithaq force-pushed the add-vcpkg-port branch 6 times, most recently from 01f402e to c301d90 Compare February 3, 2024 02:49
@Blaquewithaq
Copy link
Contributor Author

Alright, I played around with it for a few hours and now got it working with PR's

@kblaschke
Copy link
Member

kblaschke commented Feb 5, 2024

I don't think that the vcpkg port files should be part of the library repository. Adding all the packaging system files for all Linux distros and other build systems would be a huge mess.

If there are changes required like the DLL install paths, this of course should be done here, but the actual port should be committed into the upstream vpkg repository instead. Once it's there, we can still run a build here to check that changes in the library didn't break the vcpkg port (or we actually have to update the port, if the breaking change is actually required).

Using libprojectm is a good choice IMO, as it makes it clear this is just the library.

@Blaquewithaq Blaquewithaq deleted the add-vcpkg-port branch February 6, 2024 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants