Update kubelet based openshift/node #161
Conversation
|
Can one of the admins verify this patch?
|
|
@jasonbrooks The error that I mention in the commit message and I posted on the channel yesterday is fixed by mounting /sys/ like in openshift/node |
|
bot, test pull request |
|
fixes #155 too |
strigazi
force-pushed
the
update-kubelet
branch
3 times, most recently
from
da74c71 to
eea95b4
Compare
|
@giuseppe can you check this mount if it's ok? versus this on openshift |
kubernetes-kubelet/tmpfiles.template
Outdated
| @@ -0,0 +1,3 @@ | |||
| d /etc/cni/net.d - - - - - | |||
There was a problem hiding this comment.
do you want this to be a temporary file? systemd will destroy/recreate it on reboot.
If you want it to be persistent, you could do:
RUN mkdir -p /exports/hostfs/etc/cni/net.d
in your Dockerfile
There was a problem hiding this comment.
I created the dir in the dockerfile, do I also need to remove it from this list?
There was a problem hiding this comment.
yes please. Otherwise systemd-tmpfiles will still try to handle it.
|
The mounts looks fine to me, just I have one inline comment |
strigazi
force-pushed
the
update-kubelet
branch
from
eea95b4 to
3a3a792
Compare
|
@jasonbrooks @ashcrow @giuseppe let's take this in? |
|
@strigazi I still see "/etc/cni/net.d" in the tmpfiles.template file. Could you please drop that? Beside this, it looks good to me, but I'd still like @jasonbrooks to take a look at the patch. @rh-atomic-bot delegate=jasonbrooks |
|
✌️ @jasonbrooks can now approve this pull request |
|
@strigazi make that tmpfiles.template change and I'll approve |
Mount /sys/ as in node to avoid kubelet log: Failed to get system container stats for "/systemd/system.slice": failed to get cgroup stats for "/systemd/system.slice": failed to get container info for "/systemd/system.slice": unknown container "/systemd/system.slice". Mount /etc/pki to use the ca from the host. Mount /var/run/secrets needed for f27 which doesn't have kube installed and it is required by kubelet to manage kubernetes secrets. Mount tmp as tmpfs. Mount cni dirs.
strigazi
force-pushed
the
update-kubelet
branch
from
3a3a792 to
88c81b7
Compare
|
done |
|
⚡ Test exempted: pull fully rebased and already tested. |
Mount /sys/ as in node to avoid kubelet log:
Failed to get system container stats for
"/systemd/system.slice": failed to get cgroup stats
for "/systemd/system.slice": failed to get container
info for "/systemd/system.slice": unknown container
"/systemd/system.slice".
Mount /etc/pki to use the ca from the host.
Mount /var/run/secrets needed for f27 which doesn't have
kube installed and it is required by kubelet to manage
kubernetes secrets.
Mount tmp as tmpfs.
Mount cni dirs.