Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add pre-commit configuration #14

Merged
merged 1 commit into from
Jul 1, 2024
Merged

ci: Add pre-commit configuration #14

merged 1 commit into from
Jul 1, 2024

Conversation

rht
Copy link
Contributor

@rht rht commented Jun 30, 2024

No description provided.

@adamamer20
Copy link
Collaborator

Thanks. Shouldn't Black also be added?

@adamamer20
Copy link
Collaborator

Also, related to #15, do you think it would make sense to use tox/nox to ensure maximum compatibility by running tests with multiple python versions?

@rht
Copy link
Contributor Author

rht commented Jul 1, 2024

Also, related to #15, do you think it would make sense to use tox/nox to ensure maximum compatibility by running tests with multiple python versions?

The GitHub Actions CI testing (which I will set up after #15 is merged) supports running multiple Python versions declaratively. You can test only 1 version on your local machine, for faster feedback loop, and leave testing multiple versions to the CI.

@adamamer20 adamamer20 self-requested a review July 1, 2024 05:51
@rht rht merged commit e83b4ae into main Jul 1, 2024
4 checks passed
@rht rht deleted the ci_cd branch July 1, 2024 06:34
@adamamer20 adamamer20 assigned adamamer20 and rht and unassigned adamamer20 Jul 3, 2024
@adamamer20 adamamer20 added the enhancement Improvements to existing features or performance. label Jul 3, 2024
@adamamer20 adamamer20 added this to the 1.0.0 Alpha Release milestone Jul 3, 2024
@adamamer20 adamamer20 added ci Changes to CI configuration files and scripts. and removed enhancement Improvements to existing features or performance. labels Jul 5, 2024
@adamamer20 adamamer20 linked an issue Aug 25, 2024 that may be closed by this pull request
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Changes to CI configuration files and scripts.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Towards parity with Mesa's core repo practices
2 participants