Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding abstract GridDF #32

Merged
merged 4 commits into from
Jul 24, 2024
Merged

Adding abstract GridDF #32

merged 4 commits into from
Jul 24, 2024

Conversation

adamamer20
Copy link
Collaborator

This is the last abstract class before the implementation of the concrete Grid classes.

  • Normalization was added to dataframe mixin.
  • One unique class for all neighborhood types. The type is specified at the start (easier to work with than having multiple classes).
  • The neighbors are found by considering the agents in the neighborhood, not the distances between agents. Need to evaluate which is faster and whether to create a conditional implementation (eg distances with a few agents and neighborhood with many agents)

@adamamer20 adamamer20 requested a review from rht July 23, 2024 12:56
@adamamer20 adamamer20 self-assigned this Jul 23, 2024
@adamamer20 adamamer20 added the enhancement Improvements to existing features or performance. label Jul 23, 2024
@adamamer20 adamamer20 added this to the 1.0.0 Alpha Release milestone Jul 23, 2024
mesa_frames/abstract/space.py Outdated Show resolved Hide resolved
mesa_frames/abstract/space.py Outdated Show resolved Hide resolved
@rht
Copy link
Contributor

rht commented Jul 23, 2024

Other than the comments, everything else LGTM.

@adamamer20 adamamer20 linked an issue Jul 24, 2024 that may be closed by this pull request
9 tasks
@rht rht merged commit 67081d7 into main Jul 24, 2024
6 checks passed
@rht rht deleted the abstract-grid branch July 24, 2024 10:23
@adamamer20 adamamer20 linked an issue Jul 24, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements to existing features or performance.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Refactoring mesa.space Abstract GridDF
2 participants