Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Concrete GridPolars #60

Merged
merged 43 commits into from
Aug 14, 2024
Merged

Concrete GridPolars #60

merged 43 commits into from
Aug 14, 2024

Conversation

adamamer20
Copy link
Collaborator

This PR adds the Polars implementation of GridDF with tests. Right now, it's very similar to GridPandas, but in a future PR the numpy grid could be replaced with a pl.Series grid.

adamamer20 and others added 30 commits August 1, 2024 18:14
@adamamer20
adding implementation of GridPolars
c98a08d
@adamamer20
Update space.py
8d933e3
@adamamer20
fix to _df_all and _df_concat
d8cab68
@adamamer20
adding right overload to concat
98bfe11
@adamamer20
Merge branch 'main' of https://github.com/adamamer20/mesa-frames into…
015edee 
… 53-tests-for-polarsmixin
@adamamer20
change _df_filter to _df_get_masked_df + _df_all
77ad379
@adamamer20
adding custom name to _df_groupby_cumcount
9f757c8
@adamamer20
Merge branch 'main' of https://github.com/adamamer20/mesa-frames into…
7fe1933 
… 53-tests-for-polarsmixin
@adamamer20
Merge branch 'main' of https://github.com/adamamer20/mesa-frames into…
b4f757a 
… 53-tests-for-polarsmixin
@adamamer20
adding tests for PolarsMixin
3186a12
@adamamer20
fixes to PolarsMixins
93c7db3
@adamamer20
Merge branch 'main' of https://github.com/adamamer20/mesa-frames into…
f3543b9 
… 53-tests-for-polarsmixin
@adamamer20
Merge branch 'main' of https://github.com/adamamer20/mesa-frames into…
1ec89ae 
… 53-tests-for-polarsmixin
@adamamer20
Merge branch 'main' into 53-tests-for-polarsmixin
7280243
@adamamer20
Merge branch '53-tests-for-polarsmixin' of https://github.com/adamame…
34bd845 
…r20/mesa-frames into 35-concrete-gridpolars
@pre-commit-ci
[pre-commit.ci] auto fixes from pre-commit.com hooks
e3e6d91 
for more information, see https://pre-commit.ci
@adamamer20
adding index_cols to _df_join per abstract DataFrameMixin
703b561
@adamamer20
Merge branch '53-tests-for-polarsmixin' of https://github.com/adamame…
7746cc8 
…r20/mesa-frames into 53-tests-for-polarsmixin
@adamamer20
Merge branch '53-tests-for-polarsmixin' of https://github.com/adamame…
bea064a 
…r20/mesa-frames into 35-concrete-gridpolars
@adamamer20
adding greater or equal to DataFrameMixin
089900d
@adamamer20
adding boolean or to DataFrameMixin
e3423a9
@adamamer20
adding less than to DataFrameMixin
58a149d
@adamamer20
adding _df_and and _df_or
7c0f3da
@adamamer20
using mixin logical operations in space
ca42fe5
@adamamer20
fixing collections mixin
e0914ee
@adamamer20
Merge branch 'comparisons-mixin' of https://github.com/adamamer20/mes…
7e8671c 
…a-frames into 35-concrete-gridpolars
@adamamer20
adding modulus to DataFrameMixin
6187c8d
@adamamer20
adding index to DataFrameMixin
5ba1bbe
@adamamer20
fixes to method logic
9ea50e0
@adamamer20
Merge branch '53-tests-for-polarsmixin' of https://github.com/adamame…
a096a5d 
…r20/mesa-frames into comparisons-mixin
@adamamer20
Merge branch 'comparisons-mixin' of https://github.com/adamamer20/mes…
5081d18 
…a-frames into 35-concrete-gridpolars
@adamamer20
changing % to _df_mod in abstract space
c89a7ef
@adamamer20
Merge branch 'comparisons-mixin' of https://github.com/adamamer20/mes…
9ab6b9d 
…a-frames into 35-concrete-gridpolars
@adamamer20
Merge branch 'comparisons-mixin' of https://github.com/adamamer20/mes…
f715ec7 
…a-frames into 35-concrete-gridpolars
@adamamer20
Merge branch '35-concrete-gridpolars' of https://github.com/adamamer2…
b8f2399 
…0/mesa-frames into 35-concrete-gridpolars
@adamamer20
adding reindexing DataFrameMixin
4d603d3
@adamamer20
Merge branch 'comparisons-mixin' of https://github.com/adamamer20/mes…
36962cc 
…a-frames into 35-concrete-gridpolars
@adamamer20
Merge branch 'main' of https://github.com/adamamer20/mesa-frames into…
89a781d 
… 35-concrete-gridpolars
@adamamer20
fixing GridPolars logic (right now, the logic is duplicated from Grid…
d442fe1 
…Pandas, but in the future will have pl.Series instead of a numpy array)
@adamamer20
small fixes to GridDF to add GridPolars
e2643be
@adamamer20
adding tests for GridPolars
c7c141a
@adamamer20
fixes to the logic of some methods
54e25d9
@adamamer20
Merge branch 'main' into 35-concrete-gridpolars
9b4c2df
@adamamer20 adamamer20 linked an issue Aug 14, 2024 that may be closed by this pull request
Concrete GridPolars #35
Closed
@adamamer20 adamamer20 self-assigned this Aug 14, 2024
@adamamer20 adamamer20 added the enhancement Improvements to existing features or performance. label Aug 14, 2024
@adamamer20 adamamer20 added this to the 0.1.0 Alpha Release milestone Aug 14, 2024
@codecov Codecov
Copy link

codecov bot commented Aug 14, 2024

Codecov Report

Attention: Patch coverage is 97.89474% with 2 lines in your changes missing coverage. Please review.

Files Patch % Lines
mesa_frames/abstract/space.py 90.90% 1 Missing ⚠️
mesa_frames/concrete/polars/space.py 98.71% 1 Missing ⚠️
Files Coverage Δ
mesa_frames/__init__.py 100.00% <100.00%> (ø)
mesa_frames/concrete/polars/mixin.py 95.95% <100.00%> (+5.70%) ⬆️
mesa_frames/abstract/space.py 89.53% <90.90%> (+0.02%) ⬆️
mesa_frames/concrete/polars/space.py 98.71% <98.71%> (ø)

... and 1 file with indirect coverage changes

@adamamer20 adamamer20 requested a review from rht August 14, 2024 05:05
@rht
Copy link
Contributor

rht commented Aug 14, 2024

Right now, it's very similar to GridPandas, but in a future PR the numpy grid could be replaced with a pl.Series grid.

SGTM

@rht rht merged commit de65de4 into main Aug 14, 2024
7 checks passed
@rht rht deleted the 35-concrete-gridpolars branch August 14, 2024 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rht rht rht approved these changes

Assignees

@adamamer20 adamamer20

Labels
enhancement Improvements to existing features or performance.
Projects
None yet
Milestone
0.1.0 Alpha Release
Development

Successfully merging this pull request may close these issues.

Concrete GridPolars
2 participants
@adamamer20 @rht