Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix broken mesa dependencies #268

Closed
wants to merge 0 commits into from
Closed

Conversation

AdamZh0u
Copy link

This pr resolves some dependency issues caused by the mesa update.

@AdamZh0u
Copy link
Author

After updating these dependencies I tested all 7 examples in mesa-examples and they all work fine.

@wang-boyu wang-boyu added bug Release notes label dependency Release notes label labels Dec 16, 2024
Copy link

codecov bot commented Dec 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.54%. Comparing base (ce501b6) to head (9d4b3b0).
Report is 65 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #268      +/-   ##
==========================================
- Coverage   78.21%   73.54%   -4.67%     
==========================================
  Files          10       10              
  Lines         693      858     +165     
  Branches      151      131      -20     
==========================================
+ Hits          542      631      +89     
- Misses        127      194      +67     
- Partials       24       33       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@EwoutH
Copy link
Member

EwoutH commented Dec 17, 2024

Thanks for the PR! The changes look good, only our pre-commit checks are failing. Would you like to fix that yourself, or would you prefer we fix it?

@AdamZh0u
Copy link
Author

AdamZh0u commented Dec 17, 2024

Thanks for your comment @EwoutH. I'm still getting familiar with the project and I'm not sure why the N803 rule about argument names is triggered in the pre-commit as I didn't change them. I would appreciate if you could help to resolve this issue.

@wang-boyu
Copy link
Member

Hmm somehow a force push closed this PR. Let me see how to bring it back.

@wang-boyu
Copy link
Member

Might be a GitHub issue: isaacs/github#997

Updating others' PR through force push could cause problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Release notes label dependency Release notes label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants