Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: use range for supported ansible versions #117

Merged
merged 11 commits into from
Dec 12, 2023

Conversation

gardar
Copy link
Member

@gardar gardar commented May 26, 2023

@github-actions
Copy link
Contributor

github-actions bot commented May 26, 2023

Docs Build 📝

Thank you for contribution!✨

This PR has been merged and the docs are now incorporated into main:
https://prometheus-community.github.io/ansible/branch/main

@github-actions github-actions bot added trivial and removed trivial labels May 26, 2023
@gardar gardar marked this pull request as draft May 26, 2023 21:54
@github-actions github-actions bot added trivial and removed trivial labels May 27, 2023
@gardar gardar marked this pull request as ready for review May 27, 2023 03:50
@codecov-commenter
Copy link

codecov-commenter commented May 27, 2023

Codecov Report

❗ No coverage uploaded for pull request base (main@4a7fc2d). Click here to learn what that means.
The diff coverage is n/a.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@           Coverage Diff            @@
##             main      #117   +/-   ##
========================================
  Coverage        ?   100.00%           
========================================
  Files           ?         2           
  Lines           ?        38           
  Branches        ?         0           
========================================
  Hits            ?        38           
  Misses          ?         0           
  Partials        ?         0           
Flag Coverage Δ
integration 100.00% <0.00%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

@tisba
Copy link

tisba commented Jul 23, 2023

This won't work for ansible >2.15.0 (like the current 2.15.2), correct?

@ducnm0711
Copy link

The collection does not work with patch level version:

$ ansible --version
ansible [core 2.13.11]
  config file = /etc/ansible/ansible.cfg
  python version = 3.8.10 (default, May 26 2023, 14:05:08) [GCC 9.4.0]
  jinja version = 3.1.2
  libyaml = True

$ ansible-playbook commons.yml -t node_exporter
[WARNING]: Collection prometheus.prometheus does not support Ansible version 2.13.11

@theunkn0wn1
Copy link

Any plans on merging this soon?

@github-actions github-actions bot added trivial and removed trivial labels Dec 12, 2023
@github-actions github-actions bot added trivial and removed trivial labels Dec 12, 2023
@github-actions github-actions bot added trivial and removed trivial labels Dec 12, 2023
Copy link
Contributor

@SuperQ SuperQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice. I suppose later we could add an option to skip some specific versions in testing that we don't want to care about.

@gardar gardar merged commit 214f7ed into prometheus-community:main Dec 12, 2023
19 checks passed
@gardar gardar deleted the ci/ansible-version-range branch December 12, 2023 21:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Warning message does not support Ansible version 2.14.6
6 participants