-
Notifications
You must be signed in to change notification settings - Fork 139
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: use range for supported ansible versions #117
refactor: use range for supported ansible versions #117
Conversation
gardar
commented
May 26, 2023
•
edited
Loading
edited
- Use version range for collection supported Ansible versions. Previous method for listing supported versions resulted in warnings on patch level versions.
- Adds CI script for properly parsing PEP440 version ranges.
- fixes: Warning message does not support Ansible version 2.14.6 #144
Docs Build 📝Thank you for contribution!✨ This PR has been merged and the docs are now incorporated into |
Codecov Report
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more. @@ Coverage Diff @@
## main #117 +/- ##
========================================
Coverage ? 100.00%
========================================
Files ? 2
Lines ? 38
Branches ? 0
========================================
Hits ? 38
Misses ? 0
Partials ? 0
Flags with carried forward coverage won't be shown. Click here to find out more. |
7689624
to
33bf11f
Compare
This won't work for ansible >2.15.0 (like the current 2.15.2), correct? |
The collection does not work with patch level version:
|
Any plans on merging this soon? |
33bf11f
to
1a415d5
Compare
Signed-off-by: gardar <[email protected]>
Signed-off-by: gardar <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice. I suppose later we could add an option to skip some specific versions in testing that we don't want to care about.