Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

minor: Update supported Ansible versions #411

Closed
wants to merge 1 commit into from
Closed

Conversation

SuperQ
Copy link
Contributor

@SuperQ SuperQ commented Aug 19, 2024

Ansible versions 2.11 and older are not supportable on new platforms. Set the minimum supported Ansible version to 2.12 in order to make updating our integration testing possible.

  • Fixup minor linting issues.

Copy link
Contributor

github-actions bot commented Aug 19, 2024

Docs Build 📝

This PR is closed and any previously published docsite has been unpublished.

@SuperQ SuperQ force-pushed the superq/bump_ansible branch from 4ac88ec to d20d86e Compare August 19, 2024 16:50
@SuperQ SuperQ force-pushed the superq/bump_ansible branch from d20d86e to f24db7b Compare August 19, 2024 16:52
@SuperQ SuperQ changed the title breaking: Update supported Ansible versions minor: Update supported Ansible versions Aug 19, 2024
@SuperQ SuperQ force-pushed the superq/bump_ansible branch from f24db7b to de5eab4 Compare August 19, 2024 16:58
@github-actions github-actions bot added minor and removed minor labels Aug 19, 2024
@SuperQ SuperQ force-pushed the superq/bump_ansible branch from de5eab4 to e76f0f7 Compare August 19, 2024 19:47
@github-actions github-actions bot added minor and removed minor labels Aug 19, 2024
Ansible versions 2.11 and older are not supportable on new platforms.
Set the minimum supported Ansible version to 2.12 in order to make
updating our integration testing possible.
* Fixup minor linting issues.

Signed-off-by: SuperQ <[email protected]>
@SuperQ SuperQ force-pushed the superq/bump_ansible branch from e76f0f7 to 2560d04 Compare August 20, 2024 04:27
@github-actions github-actions bot added minor and removed minor labels Aug 20, 2024
@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 20, 2024

@gardar Fixed up, removing centos-7 here instead of #395 to make some tests pass.

Copy link
Member

@gardar gardar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was hoping centos 7 would be the last version using 2.9 but I don't think we can fully remove the old ansible versions yet, as for example ubuntu 20.04 doesn't have anything newer than 2.9 in the repos, not even in the backports https://packages.ubuntu.com/focal/ansible 😔
I'd much prefer that we add exclusions to the matrix as I mentioned here: #395 (comment)

@SuperQ
Copy link
Contributor Author

SuperQ commented Aug 21, 2024

Ok, if you have a hint on how/where you were going to add the version matrix list, I could work on it.

@gardar
Copy link
Member

gardar commented Aug 21, 2024

I'm not absolutely certain where it would be best to place the exclusion list, I don't think that it would fit in any of the ansible meta files. So I guess it would either have to be under env: in .github/workflows/ansible-ci.yml on in some new file under .github/

Something like this for example:

env:
  EXCLUSIONS: |
            - target: ubuntu-24.04
              ansible-core-version: 
                - stable-2.10
                - stable-2.11

Then we need to add it to the matrix json that's dynamically generated and used in .github/workflows/ansible-test-molecule.yml

The matrix that's currently generated ends something like this:

jobs:
  ansible-test-integration:
    runs-on: ubuntu-latest
    strategy:
      fail-fast: false
      max-parallel: 4
      matrix:
        target: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04]
        ansible-core-version: [stable-2.10, stable-2.11, stable-2.12, stable-2.13]

but after adding the excludes it would end something like this:

jobs:
  ansible-test-integration:
    runs-on: ubuntu-latest
    strategy:
      fail-fast: false
      max-parallel: 4
      matrix:
        target: [ubuntu-20.04, ubuntu-22.04, ubuntu-24.04]
        ansible-core-version: [stable-2.10, stable-2.11, stable-2.12, stable-2.13]
        exclude:
          - target: ubuntu-24.04
            ansible-core-version: 
              - stable-2.10
              - stable-2.11

@SuperQ
Copy link
Contributor Author

SuperQ commented Sep 14, 2024

Closing in favor of #416.

@SuperQ SuperQ closed this Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment